Skip to content

[SPIRV] Handle a cast to void #7227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
s-perron merged 1 commit into from
Mar 19, 2025
Merged

[SPIRV] Handle a cast to void #7227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions tools/clang/lib/SPIRV/SpirvEmitter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3657,14 +3657,16 @@ SpirvInstruction *SpirvEmitter::doCastExpr(const CastExpr *expr,
emitError("implicit cast kind '%0' unimplemented", expr->getExprLoc())
<< expr->getCastKindName() << expr->getSourceRange();
expr->dump();
return 0;
return nullptr;
}
}
case CastKind::CK_ToVoid:
return nullptr;
default:
emitError("implicit cast kind '%0' unimplemented", expr->getExprLoc())
<< expr->getCastKindName() << expr->getSourceRange();
expr->dump();
return 0;
return nullptr;
}
}

Expand Down
18 changes: 18 additions & 0 deletions tools/clang/test/CodeGenSPIRV/cast.to.void.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
// RUN: %dxc dxc -T cs_6_6 -E Main -spirv %s -fcgl | FileCheck %s


// Make sure no code is generated for the cast to void.

// CHECK: %src_Main = OpFunction %void None
// CHECK-NEXT: OpLabel
// CHECK-NEXT: %x = OpVariable
// CHECK-NEXT: OpStore %x %false
// CHECK-NEXT: OpReturn
// CHECK-NEXT: OpFunctionEnd

[numthreads(1, 1, 1)]
void Main()
{
bool x = false;
(void)x;
}