Always enable SPIR-V#7221
Conversation
disables the ability to disable SPIR-V. This allows intermediate opcodes to be consistent at least across the same compiler build regardless of build environment. This is a requirement for IR tests that depend on these opcodes. Given the embrace of SPIR-V and the stability the generation target has gained, there's no reason not to do this. Fixes microsoft#7169
|
Note that I've enabled this by force rather than just enabling it by default to address existing installs. This does mean that some will have to get the SPIRV subdirs to get what they need, but the alternative is seemingly failing IR tests |
might be a problem since some of this is generated code
|
format checker is refusing to find he latest hash. null change incoming |
|
Well, there seems to be no satisfying the formatting bot for the present. |
damyanp
left a comment
damyanp
left a comment
There was a problem hiding this comment.
LGTM - would it also be good to get a review from some of the developers working on SPIR-V as well?
Is there any documentation in the repo that needs updating? READMEs etc?
|
I assure you this was clang-formatted. The bot is having a bad week. Bypassing. |
I didn't see this comment before my last comment for security reasons. These are good suggestions. |
|
Given that we have another way to solve the problem of different configurations with the same build failing IR test due to instable opcode values with #7231, suddenly requiring the SPIRV submodules upon syncing to the latest is no longer the lesser evil as tests will no longer suddenly fail on SPIRV disabled builds. As such, we are still determined to change the default to enabling SPIRV, but it will be just a few lines changing defaults in cmake and batch files. This change doesn't bear sufficient resemblance to that eventual simple, though impactful change, so I'm closing it. |
5 participants
disables the ability to disable SPIR-V. This allows intermediate opcodes to be consistent at least across the same compiler build regardless of build environment. This is a requirement for IR tests that depend on these opcodes.
Given the embrace of SPIR-V and the stability the generation target has gained, there's no reason not to do this.
Fixes #7169