Disallow swizzling on long vectors#7215
Merged
alsepkow merged 3 commits intomicrosoft:mainfrom Mar 18, 2025
Merged
Conversation
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
llvm-beanz
approved these changes
Mar 18, 2025
Collaborator
llvm-beanz
left a comment
llvm-beanz
left a comment
There was a problem hiding this comment.
One nit, otherwise looks good.
alsepkow
force-pushed
the
user/alsepkow/NoLongVecSwizzle
branch
from
0e6d803 to
c050537
Compare
alsepkow
commented
Mar 18, 2025
llvm-beanz
requested changes
Mar 18, 2025
llvm-beanz
approved these changes
Mar 18, 2025
pow2clk
approved these changes
Mar 18, 2025
Collaborator
pow2clk
left a comment
pow2clk
left a comment
There was a problem hiding this comment.
Thanks for doing this!
If you add Fixes #7194 to the description, it will close the bug automatically
farzonl
reviewed
Mar 18, 2025
| export TYPE lv_ctor(TYPE s) { | ||
| TYPE ret = (vector<TYPE,6>(1, 2, 3, 4, 5, s)).x; // expected-error {{invalid swizzle 'x' on vector of over 4 elements.}} | ||
| return ret; | ||
| } No newline at end of file |
Collaborator
There was a problem hiding this comment.
you need an extra space here.
Contributor
Author
There was a problem hiding this comment.
An extra space where?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #7194 by adding a new error string in DiagnosticSemaKinds.td and emitting it in SemaHLSL.cpp.
@pow2clk implemented most of this in his fork. I'm just helping to finish it.
How verified: