Add vk::LocalSizeId Attribute#7084
Draft
s-perron wants to merge 1 commit intomicrosoft:mainfrom
Draft
Conversation
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
In SPIR-V, the number of thread in the group can be specificed using the `LocalSize` execution mode. This corresponds nicely with the `numthreads` attribute in HLSL. However there is another way. You can use `LocalSizeId`, which uses ids of other instructions. This allows spec constants to be provided as a dimention on the local size id. This PR adds a new attribute that can be used instead of the `numthreads` attribute. It allows constant expression or spec constants as parameters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In SPIR-V, the number of thread in the group can be specificed using the
LocalSizeexecution mode. This corresponds nicely with thenumthreadsattribute in HLSL.However there is another way. You can use
LocalSizeId, which uses idsof other instructions. This allows spec constants to be provided as a
dimention on the local size id.
This PR adds a new attribute that can be used instead of the
numthreadsattribute. It allows constant expression or spec constantsas parameters.