[NFC][CMAKE] Fix warning on MacOS build (#8166)

This commit fixes 2 warnings showing on when building on MacOS:
 - CMP0135: setting which policy is applied on download freshness check
 - METAL_IRCONVERTER case not matching the FindPackage filename.

Author: Keenuts

cmake/config-ix.cmake

@@ -573,7 +573,7 @@ string(REPLACE " " ";" LLVM_BINDINGS_LIST "${LLVM_BINDINGS}")
 
 # HLSL Change Begin - Metal IR Converter
 find_package(MetalIRConverter)
-if (METAL_IRCONVERTER_FOUND)
+if (MetalIRConverter_FOUND)
   set(ENABLE_METAL_CODEGEN On)
   message(STATUS "Enabling Metal Support")
   add_definitions(-DENABLE_METAL_CODEGEN)

cmake/modules/FindMetalIRConverter.cmake

@@ -1,16 +1,16 @@
-find_path(METAL_IRCONVERTER_INCLUDE_DIR metal_irconverter.h
+find_path(MetalIRConverter_INCLUDE_DIR metal_irconverter.h
           HINTS /usr/local/include/metal_irconverter
           DOC "Path to metal IR converter headers"
           )
 
-find_library(METAL_IRCONVERTER_LIB NAMES metalirconverter
+find_library(MetalIRConverter_LIB NAMES metalirconverter
   PATH_SUFFIXES lib
   )
 
 include(FindPackageHandleStandardArgs)
-FIND_PACKAGE_HANDLE_STANDARD_ARGS(METAL_IRCONVERTER
-                                    REQUIRED_VARS METAL_IRCONVERTER_LIB METAL_IRCONVERTER_INCLUDE_DIR)
+FIND_PACKAGE_HANDLE_STANDARD_ARGS(MetalIRConverter
+                                  REQUIRED_VARS MetalIRConverter_LIB MetalIRConverter_INCLUDE_DIR)
 
-message(STATUS "Metal IR Converter Include Dir: ${METAL_IRCONVERTER_INCLUDE_DIR}")
-message(STATUS "Metal IR Converter Library: ${METAL_IRCONVERTER_LIB}")
-mark_as_advanced(METAL_IRCONVERTER_LIB METAL_IRCONVERTER_INCLUDE_DIR)
+message(STATUS "Metal IR Converter Include Dir: ${MetalIRConverter_INCLUDE_DIR}")
+message(STATUS "Metal IR Converter Library: ${MetalIRConverter_LIB}")
+mark_as_advanced(MetalIRConverter_LIB MetalIRConverter_INCLUDE_DIR)

tools/clang/test/CMakeLists.txt

@@ -135,6 +135,7 @@ function(add_released_dxc name version)
       CONFIGURE_COMMAND ""
       BUILD_COMMAND ""
       INSTALL_COMMAND ""
+      DOWNLOAD_EXTRACT_TIMESTAMP NEW
   )
 endfunction()
 

tools/clang/tools/dxcompiler/CMakeLists.txt

@@ -135,12 +135,12 @@ if (ENABLE_SPIRV_CODEGEN)
   target_link_libraries(dxcompiler PRIVATE clangSPIRV)
 endif (ENABLE_SPIRV_CODEGEN)
 if (ENABLE_METAL_CODEGEN)
-  target_link_libraries(dxcompiler PRIVATE ${METAL_IRCONVERTER_LIB})
-  target_include_directories(dxcompiler PRIVATE ${METAL_IRCONVERTER_INCLUDE_DIR})
+  target_link_libraries(dxcompiler PRIVATE ${MetalIRConverter_LIB})
+  target_include_directories(dxcompiler PRIVATE ${MetalIRConverter_INCLUDE_DIR})
 
-  get_filename_component(METAL_IRCONVERTER_LIB_DIR ${METAL_IRCONVERTER_LIB} DIRECTORY CACHE)
+  get_filename_component(MetalIRConverter_LIB_DIR ${MetalIRConverter_LIB} DIRECTORY CACHE)
   set_property(TARGET dxcompiler APPEND_STRING
-               PROPERTY LINK_FLAGS " -Wl,-rpath,${METAL_IRCONVERTER_LIB_DIR}")
+               PROPERTY LINK_FLAGS " -Wl,-rpath,${MetalIRConverter_LIB_DIR}")
 endif (ENABLE_METAL_CODEGEN)
 include_directories(AFTER ${LLVM_INCLUDE_DIR}/dxc/Tracing ${DIASDK_INCLUDE_DIRS} ${HLSL_VERSION_LOCATION})
 include_directories(${LLVM_SOURCE_DIR}/tools/clang/tools/dxcvalidator)