improve TestDeleteContext robustness and isolation using temporary directories#314
Closed
Manar-Elhabbal7 wants to merge 2 commits intomicrocks:masterfrom
Closed
improve TestDeleteContext robustness and isolation using temporary directories#314Manar-Elhabbal7 wants to merge 2 commits intomicrocks:masterfrom
Manar-Elhabbal7 wants to merge 2 commits intomicrocks:masterfrom
Conversation
Manar-Elhabbal7
requested review from
Harsh4902,
lbroudoux and
yada
as code owners
|
Welcome to the Microcks community! 💖 Thanks and congrats 🎉 for opening your first pull request here! Be sure to follow the pull request template or please update it accordingly. Hope you have a great time there! |
Signed-off-by: Manar Elhabbal <[email protected]>
Signed-off-by: Manar Elhabbal <[email protected]>
Manar-Elhabbal7
force-pushed
the
refactor/test-config-tempdir
branch
from
9c2052f to
41aed5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a brittle test case in
cmd/context_test.gowhere TestDeleteContext was failing onnon-Unix-native filesystems (like NTFS/FAT).
The test previously relied on a static file path in ./testdata/, which caused issues when trying to set
and verify restrictive file permissions (0600). By switching to t.TempDir(), the test is now isolated,
environment-agnostic, and leaves no garbage files behind.
Changes
Related issue(s) : #313