fix : start and stop commands crash when container state diverges from local config#307
Open
DivyanshuVortex wants to merge 3 commits intomicrocks:masterfrom
Open
fix : start and stop commands crash when container state diverges from local config#307DivyanshuVortex wants to merge 3 commits intomicrocks:masterfrom
start and stop commands crash when container state diverges from local config#307DivyanshuVortex wants to merge 3 commits intomicrocks:masterfrom
Conversation
…er itself Signed-off-by: DivyanshuVorrtex <[email protected]>
Contributor
Author
|
Removed |
Signed-off-by: DivyanshuVorrtex <[email protected]>
start and stop commands crash when container state diverges from local config
Signed-off-by: DivyanshuVorrtex <[email protected]>
|
@DivyanshuVortex, how do you temporarily deploy your PR to build? |
Contributor
Author
GitHub Actions is set to auto-run on PR , so the temp Build deploy just kicked off automatically when the PR got opened/updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description :
microcks startto sync with daemon state before starting containersmicrocks stopto handle already-removed containers gracefullyUpsertInstanceto match byNameinstead ofContainerID~/.config/microcks/configGetContainer(name)to inspect real container state from Docker/PodmanResolves : #306