Drop support for Node.js 18#499
Merged
remcohaszing merged 1 commit intomainfrom Apr 13, 2025
Merged
Conversation
The asynchronous TypeScript plugin keeps causing issues. The goal is to move away from that and make it synchronous. Node.js 20.19 adds support for `require(esm)`, which is a great first step for our use case. VSCode currently ships with Node.js 20.18. However, this is still fine, as dependencies are bundled in the VSCode extension.
remcohaszing
added
🦋 type/enhancement
🦋 Changeset detectedLatest commit: 09852e9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #499 +/- ##
=======================================
Coverage 92.02% 92.02%
=======================================
Files 10 10
Lines 1769 1769
=======================================
Hits 1628 1628
Misses 141 141 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
The asynchronous TypeScript plugin keeps causing issues. The goal is to move away from that and make it synchronous. Node.js 20.19 adds support for
require(esm), which is a great first step for our use case.VSCode currently ships with Node.js 20.18. However, this is still fine, as dependencies are bundled in the VSCode extension.