This repository was archived by the owner on Nov 22, 2021. It is now read-only.
Add overlay attribute#815
Open
SamarRizvi wants to merge 5 commits intombenford:masterfrom
Open
Conversation
Add overlay attribute to auto-complete directive so that if inside a container (like, for example, table) the suggestion list is outside the container and not inside. Also keep the auto-complete height to 0 as it gives unnecessary scroll when inside a container.
Add necessary styling for overlay attribute.
Make ng-style less complex. Using function call instead.
Create overlayStyle object to use in ng-style in template
Use overlayStyle object for ng-style that is set in auto-complete directive when overlay attribute is true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add overlay attribute to auto-complete directive so that if inside a container (like, for example, table) the suggestion list is outside the container and not inside. Also keep the auto-complete height to 0 as it gives unnecessary scroll when inside a container.