Skip to content
This repository was archived by the owner on Nov 22, 2021. It is now read-only.

Array of strings#679

Open
sebastiannm wants to merge 3 commits intombenford:masterfrom
Nex9:item-as-string
Open

Array of strings#679
sebastiannm wants to merge 3 commits intombenford:masterfrom
Nex9:item-as-string

Conversation

@sebastiannm
Copy link
Copy Markdown

@sebastiannm sebastiannm commented Jun 8, 2016

Hi, I worked on a feature that is very much requested.

Turning off itemIsObject (on by default for backwards compatibility) will create an array of strings instead of objects. I'm using it in production without problems.

@mohag519
Copy link
Copy Markdown

mohag519 commented Jun 9, 2016

Excellent thanks!

@nescalante
Copy link
Copy Markdown

+1
seems to solve #666

@jrdn91
Copy link
Copy Markdown

jrdn91 commented Sep 29, 2016

Any plans on when this will be merged into master? I'm working with this directive right now but I'm having to do serialization because I need an array of strings rather than an array of objects

@gustavodegeus
Copy link
Copy Markdown

+1

1 similar comment
@mjmarianetti
Copy link
Copy Markdown

+1

@repalogic
Copy link
Copy Markdown

@sebastiannm Could you make your repository public so that it might be possible to merge your changes in an own fork. So your changes would be reusable by others until the pull request will be accepted here.

@nescalante
Copy link
Copy Markdown

@repalogic: https://github.com/Nex9/ngTagsInput

@matthew-mahony
Copy link
Copy Markdown

I have a problem where auto complete does not work when I set item-is-object to false. When typing in the tags field, I get an error in the console "array1.filter is not a function".

I fixed the error by changing:
getDifference(items, tags);
to
getDifference(items.data || items, tags);

When item-is-object is enabled, the items.data is used when available, but that check is missing when using simple arrays.

@ronaldohoch
Copy link
Copy Markdown

Hello.

It will be released soon in bower?

@tkserver
Copy link
Copy Markdown

Thanks @nescalante this solved my problem! Needed an array strings, not objects. I would like to know when this is merged with the original base code.

@edmedo
Copy link
Copy Markdown

edmedo commented Aug 23, 2017

Hi, are we any closer to getting this merged? Seems to me this is a requirement for many people. I'd prefer not to have to transform my model the entire time to hack around this problem :-/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.