Conversation
Contributor
|
I am a bot, here are the test results for this PR:
|
Contributor
|
I am a bot, here are the test results for this PR:
|
thespad
approved these changes
May 8, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
jenkins-vars.ymlargumentbuild_riscv64(defaultfalse)When set to true, it does the following:
Dockerfile.riscv64on native riscv64 builder and pushes toriscv64tagAvailable Architecturesin the readme (if set to false, it does not add a red X, so existing readmes without riscv64 are not modified) locally tested:Requires:
MULTIARCH=trueinjenkins-vars.yml(not able to build only amd64 and riscv64)If
build_riscv64is not defined or set to false, it does not modify existing readmes or Jenkinsfiles so this PR shold not have any impact on existing repo templates (locally tested)Test results:
baseimage-alpine:edgedev build with locally generated Jenkinsfile: https://ci.linuxserver.io/blue/organizations/jenkins/Docker-Pipeline-Builders%2Fdocker-baseimage-alpine/detail/edge-riscv64/1/pipeline/CI test results: https://ci-tests.linuxserver.io/lsiodev/alpine/edge-67abfac6-pkg-67abfac6-dev-df89f330680499dc1d4c0a487ef1b8acb58b4bf4/index.html
docker-cicontainer is already updated to support riscv64 as a valid platform.One decision that needs to be made by the team is w/ regards to qemu builds. Currently our ci allows for building arm64 on X86_64 hw via qemu by settinguse_qemuto true. This PR uses the same functionality for riscv64 as well. However, due to limited hw availability for riscv64 (and the surprisingly good qemu build performance), we may wish to have native arm64 but qemu riscv64 for some repos. If that's desired, I can add a new argument, perhapsuse_qemu_riscv64? Let me knowI went ahead and added
orstatements to both arm64 and riscv64 build blocks with new optional argsuse_qemu_arm64anduse_qemu_riscv64so that we can have them use qemu for one or both.use_qemu: trueboth arm64 and riscv64 use qemuuse_qemu_arm64: trueonly arm64 uses qemuuse_qemu_riscv64:trueonly riscv64 uses qemu