ci: ansible-lint requires dependencies to be installed [citest_skip]

[richm]

ansible-lint requires the dependencies in meta/collection-requirements.yml
and tests/collection-requirements.yml to be installed. tox-lsr 3.18.1
will ensure they are installed.

Refactor the tests somewhat so that the collection and test steps are separate.

Signed-off-by: Rich Megginson [email protected]

Summary by Sourcery

Update CI workflows to use tox-lsr 3.18.1 and separate Ansible collection conversion from lint and test execution.

CI:

• Bump tox-lsr version from 3.18.0 to 3.18.1 across all GitHub Actions workflows.
• Split Ansible collection conversion into its own tox step before running ansible-lint and ansible-test in CI.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI workflows to use tox-lsr 3.18.1 and refactors ansible-lint and ansible-test jobs to run collection conversion and lint/test steps separately, aligning with new dependency handling requirements.

Flow diagram for updated ansible-lint GitHub Actions workflow

flowchart TD
  A[Push or pull_request event] --> B[GitHub Actions runner]
  B --> C[Checkout repository]
  C --> D[Install tox and tox_lsr 3_18_1]
  D --> E[Set up Python matrix version]
  E --> F[Run tox -e collection
Convert role to collection format]
  F --> G[Set env vars LSR_ANSIBLE_LINT_DEP and LSR_ANSIBLE_LINT_ANSIBLE_DEP]
  G --> H[Run tox -e ansible-lint-collection
Execute ansible-lint on converted collection]
  H --> I[Report ansible-lint results]

Loading

File-Level Changes

Change	Details	Files
Bump tox-lsr version used in CI workflows to 3.18.1.	Update pip install commands in GitHub Actions workflows to reference [email protected] instead of 3.18.0	.github/workflows/ansible-lint.yml .github/workflows/ansible-test.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/python-unit-test.yml .github/workflows/qemu-kvm-integration-tests.yml
Refactor ansible-lint workflow to run collection build separately from linting.	Split combined step into a dedicated 'Convert role to collection format' step running tox -e collection Adjust ansible-lint step so tox only runs the ansible-lint-collection environment while still passing in ansible/ansible-lint version variables and basepython override	.github/workflows/ansible-lint.yml
Refactor ansible-test workflow to separate collection build from ansible-test execution.	Add a dedicated step to run tox -e collection for collection conversion Change ansible-test step to run only ansible-test-<ansible version> tox env while keeping the basepython override in tox -x	.github/workflows/ansible-test.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}