ci: Comply with Ansible partner certification checking [citest_skip]#612
Merged
ci: Comply with Ansible partner certification checking [citest_skip]#612
Conversation
https://github.com/ansible-collections/partner-certification-checker/blob/main/README.md Unfortunately we cannot use the checkers provided by their team because they assume the git repo is in collection format - you cannot convert to collection format first then point the checkers at that collection. Instead, implement our own checkers that do the same (and more) - check with multiple versions of ansible-lint and ansible-test to ensure we cover: * all supported versions of EL * Automation Hub gating * the latest versions of Ansible, including the latest milestone version This requires the latest version of tox-lsr Signed-off-by: Rich Megginson <[email protected]>
Reviewer's GuideUpdates GitHub Actions CI to align with Ansible partner certification requirements by running ansible-lint and ansible-test via tox-lsr across multiple Ansible/Python versions and bumping tox-lsr to 3.18.0 throughout workflows. Flow diagram for updated ansible-lint CI job with matrix and tox-lsrflowchart TD
trigger["PR or push event (without [citest_skip])"] --> job_start["Start ansible-lint job"]
job_start --> define_matrix["Define matrix of ansible-lint, ansible-core, python versions"]
define_matrix --> update_tools["Update pip and git"]
update_tools --> install_tox_lsr["pip install tox-lsr 3.18.0 from Git"]
install_tox_lsr --> setup_python["actions/setup-python with matrix python-version"]
setup_python --> run_tox["Run tox with envs collection and ansible-lint-collection"]
run_tox --> set_env_deps["Set LSR_ANSIBLE_LINT_DEP and LSR_ANSIBLE_LINT_ANSIBLE_DEP for matrix"]
set_env_deps --> tox_collection["tox env collection (convert role to collection)"]
tox_collection --> tox_ansible_lint_collection["tox env ansible-lint-collection (run ansible-lint)"]
tox_ansible_lint_collection --> job_result["Report ansible-lint results for this matrix entry"]
job_result --> matrix_aggregate["Aggregate results across matrix entries"]
matrix_aggregate --> workflow_status["Set overall workflow status"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/ansible-collections/partner-certification-checker/blob/main/README.md
Unfortunately we cannot use the checkers provided by their team because they assume
the git repo is in collection format - you cannot convert to collection format first
then point the checkers at that collection. Instead, implement our own checkers that
do the same (and more) - check with multiple versions of ansible-lint and ansible-test
to ensure we cover:
This requires the latest version of tox-lsr
Signed-off-by: Rich Megginson [email protected]
Summary by Sourcery
Update Ansible CI workflows to align with partner certification requirements by running linting and testing across multiple supported Ansible and Python versions via tox-lsr.
Enhancements:
Build:
CI: