tests: Fix verification for LVM pool on top encrypted MD RAID

[vojtechtrefny]

Resolves: RHEL-95719

Summary by Sourcery

Extend test suite to cover encrypted RAID1 LVM pools and correct related verifications

Bug Fixes:

• fix mdadm detail command to reference /dev/md/-1
• skip pool-member assertions for encrypted LVM pools

Tests:

• add create, verify, and remove tests for encrypted RAID1 LVM pools
• renumber verify-role-results tasks after inserting encrypted pool tests
• update verify-pool-md to use consistent md device naming
• exclude encrypted pools in test-verify-pool-members assertions

[sourcery-ai]

Reviewer's Guide

This PR extends storage role tests to support encrypted RAID1 LVM pools by adding a full create-verify-remove scenario, renumbering existing verification steps, updating RAID verification to use explicit /dev/md paths, and skipping pool-member assertions for encrypted pools.

File-Level Changes

Change	Details	Files
Add encrypted RAID1 LVM pool test scenario	Add task to create encrypted RAID1 LVM device Add verification task after creation Add task to remove encrypted LVM pool Add verification task after removal	tests/tests_create_raid_pool_then_remove.yml
Renumber existing verify/remove steps to accommodate new tests	Update “Verify role results - 12” to “14” Update “Remove the device created above - 5” to “6” Update “Verify role results - 13” to “15”	tests/tests_create_raid_pool_then_remove.yml
Use explicit /dev/md path for RAID verification	Change mdadm command to reference /dev/md/{{ storage_test_pool.name }}-1 instead of generic PV path	tests/verify-pool-md.yml
Skip pool-member assertions for encrypted pools	Add condition to skip member checks when storage_test_pool.encryption is true	tests/test-verify-pool-members.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 10.66%. Comparing base (59fd1c6) to head (ad5ec3f).
⚠️ Report is 76 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (59fd1c6) and HEAD (ad5ec3f). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (59fd1c6)	HEAD (ad5ec3f)
sanity	1	0

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #549      +/-   ##
==========================================
- Coverage   16.54%   10.66%   -5.89%     
==========================================
  Files           2        8       +6     
  Lines         284     1960    +1676     
  Branches       79        0      -79     
==========================================
+ Hits           47      209     +162     
- Misses        237     1751    +1514     

Flag	Coverage Δ
sanity	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[richm]

[citest]

[sourcery-ai]

Hey @vojtechtrefny - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[richm]

[citest_bad]

[richm]

I will fix the 2.9 failures in a separate commit