Skip to content

refactor: correct volume names changed by previous fix#543

Merged
richm merged 1 commit intolinux-system-roles:mainfrom
richm:fix-ansible-lint-2
Jul 9, 2025
Merged

refactor: correct volume names changed by previous fix#543
richm merged 1 commit intolinux-system-roles:mainfrom
richm:fix-ansible-lint-2

Conversation

@richm
Copy link
Copy Markdown
Contributor

@richm richm commented Jul 8, 2025

Signed-off-by: Rich Megginson [email protected]

Summary by Sourcery

Tests:

  • Remove "- 2" and "- 3" suffixes from volume names (Lv2 and Lv3) in tests/tests_raid_pool_options.yml to restore expected naming conventions.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Jul 8, 2025

Reviewer's Guide

This PR adjusts the test configuration by removing outdated numeric suffixes from logical volume names in the RAID pool options playbook.

File-Level Changes

Change Details Files
Removed numeric suffixes from logical volume names in the test configuration
  • Replaced “Lv2 - 2” with “Lv2”
  • Replaced “Lv3 - 2” with “Lv3”
  • Replaced “Lv2 - 3” with “Lv2”
  • Replaced “Lv3 - 3” with “Lv3”
tests/tests_raid_pool_options.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @richm - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm
Copy link
Copy Markdown
Contributor Author

richm commented Jul 8, 2025

[citest]

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.64%. Comparing base (59fd1c6) to head (cb9137d).
Report is 68 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (59fd1c6) and HEAD (cb9137d). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (59fd1c6) HEAD (cb9137d)
sanity 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #543      +/-   ##
==========================================
- Coverage   16.54%   10.64%   -5.91%     
==========================================
  Files           2        8       +6     
  Lines         284     1964    +1680     
  Branches       79        0      -79     
==========================================
+ Hits           47      209     +162     
- Misses        237     1755    +1518     
Flag Coverage Δ
sanity ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@richm
Copy link
Copy Markdown
Contributor Author

richm commented Jul 9, 2025

[citest_bad]

@richm richm merged commit d75257d into linux-system-roles:main Jul 9, 2025
36 of 37 checks passed
@richm richm deleted the fix-ansible-lint-2 branch July 9, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants