try with sourcery config file#528
Conversation
Reviewer's GuideThis pull request introduces a Sourcery configuration file ( File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @richm - I've reviewed your changes - here's some feedback:
- Verify the
python_versioninsourcery.yaml(currently '3.6') aligns with the project's actual minimum Python target. - Review the list of disabled Sourcery rules in
sourcery.yaml(e.g., for f-strings, dict/list literals) to ensure it reflects the intended style choices for this project.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| - refactoring | ||
| - suggestion | ||
| - comment | ||
| python_version: "3.6" |
There was a problem hiding this comment.
suggestion: Consider updating the python_version as 3.6 is approaching end-of-life.
Upgrading to a newer Python version ensures better compatibility, performance, and alignment with current standards.
| python_version: "3.6" | |
| python_version: "3.9" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #528 +/- ##
==========================================
- Coverage 16.54% 10.72% -5.83%
==========================================
Files 2 8 +6
Lines 284 1949 +1665
Branches 79 0 -79
==========================================
+ Hits 47 209 +162
- Misses 237 1740 +1503
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary by Sourcery
Configure Sourcery AI code review action with a custom configuration file
CI:
Chores: