fix: Correctly check PVs for grow_to_fill feature#523
Merged
richm merged 1 commit intolinux-system-roles:mainfrom May 1, 2025
Merged
fix: Correctly check PVs for grow_to_fill feature#523richm merged 1 commit intolinux-system-roles:mainfrom
richm merged 1 commit intolinux-system-roles:mainfrom
Conversation
We need to check the size of the PV format and compare it to the size of the underlying block device when deciding if the format size should be grown. The size of the VG (self._device here) is not relevant for this operation. This code used to work because of a bug in blivet where size of the VG was incorrectly calculated for PVs with size not matching the underlying block device size, this was fixed in blivet (see storaged-project/blivet#1334) so the grow_to_fill feature no longer works without this fix.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #523 +/- ##
==========================================
- Coverage 16.54% 10.72% -5.83%
==========================================
Files 2 8 +6
Lines 284 1949 +1665
Branches 79 0 -79
==========================================
+ Hits 47 209 +162
- Misses 237 1740 +1503
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
[citest] |
Contributor
|
[citest_bad] |
richm
approved these changes
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to check the size of the PV format and compare it to the size of the underlying block device when deciding if the format size should be grown. The size of the VG (self._device here) is not relevant for this operation.
This code used to work because of a bug in blivet where size of the VG was incorrectly calculated for PVs with size not matching the underlying block device size, this was fixed in blivet (see storaged-project/blivet#1334) so the grow_to_fill feature no longer works without this fix.
Note: The blivet fix for the PV format size is now included in both Fedora and RHEL 9 and 10, but this fix is backwards compatible and should work with older blivet too.