Skip to content

fix: Correctly check PVs for grow_to_fill feature#523

Merged
richm merged 1 commit intolinux-system-roles:mainfrom
vojtechtrefny:main_fix-auto-pvresize
May 1, 2025
Merged

fix: Correctly check PVs for grow_to_fill feature#523
richm merged 1 commit intolinux-system-roles:mainfrom
vojtechtrefny:main_fix-auto-pvresize

Conversation

@vojtechtrefny
Copy link
Copy Markdown
Collaborator

We need to check the size of the PV format and compare it to the size of the underlying block device when deciding if the format size should be grown. The size of the VG (self._device here) is not relevant for this operation.
This code used to work because of a bug in blivet where size of the VG was incorrectly calculated for PVs with size not matching the underlying block device size, this was fixed in blivet (see storaged-project/blivet#1334) so the grow_to_fill feature no longer works without this fix.

Note: The blivet fix for the PV format size is now included in both Fedora and RHEL 9 and 10, but this fix is backwards compatible and should work with older blivet too.

We need to check the size of the PV format and compare it to the
size of the underlying block device when deciding if the format
size should be grown. The size of the VG (self._device here) is
not relevant for this operation.
This code used to work because of a bug in blivet where size of
the VG was incorrectly calculated for PVs with size not matching
the underlying block device size, this was fixed in blivet (see
storaged-project/blivet#1334) so the
grow_to_fill feature no longer works without this fix.
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 10.72%. Comparing base (59fd1c6) to head (569e5b5).
Report is 47 commits behind head on main.

Files with missing lines Patch % Lines
library/blivet.py 0.00% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (59fd1c6) and HEAD (569e5b5). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (59fd1c6) HEAD (569e5b5)
sanity 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #523      +/-   ##
==========================================
- Coverage   16.54%   10.72%   -5.83%     
==========================================
  Files           2        8       +6     
  Lines         284     1949    +1665     
  Branches       79        0      -79     
==========================================
+ Hits           47      209     +162     
- Misses        237     1740    +1503     
Flag Coverage Δ
sanity ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@richm
Copy link
Copy Markdown
Contributor

richm commented Apr 30, 2025

[citest]

@richm
Copy link
Copy Markdown
Contributor

richm commented May 1, 2025

[citest_bad]

@richm richm merged commit f8bd640 into linux-system-roles:main May 1, 2025
25 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants