tests: Fix more cleanups; ci: Attach batch.txt and batch.report on failures#519
Merged
richm merged 3 commits intolinux-system-roles:mainfrom Apr 16, 2025
Merged
tests: Fix more cleanups; ci: Attach batch.txt and batch.report on failures#519richm merged 3 commits intolinux-system-roles:mainfrom
richm merged 3 commits intolinux-system-roles:mainfrom
Conversation
batch.txt is not predictable (tests are run in file system order, not asciibetically or otherwise reproducibly). To aid with local reproduction, attach the generated batch file to the test artifact.
Commit d038078 only added cleanups for half of the tests, these are the other two.
Always run the cleanup task, so that subsequent tests don't run into the existing pool.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #519 +/- ##
==========================================
- Coverage 16.54% 10.72% -5.83%
==========================================
Files 2 8 +6
Lines 284 1949 +1665
Branches 79 0 -79
==========================================
+ Hits 47 209 +162
- Misses 237 1740 +1503
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Apr 16, 2025
Merged
richm
approved these changes
Apr 16, 2025
vojtechtrefny
approved these changes
Apr 16, 2025
Contributor
Author
|
Nice, as planned -- the run is down to three failures, and tests_lvm_pool_pv_grow failed correctly |
Contributor
|
@martinpitt ready to merge? |
Contributor
Author
|
Yes! I'm just not sure about that codecov failure, is that "expected"? |
Contributor
Yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the
tests_remove_mount.ymlandtests_existing_lvm_pool.ymlfollow-up failures from #518 (comment) . It should also maketests_lvm_pool_pv_grow.ymlfail "correctly", i.e. with the "Unexpected difference between PV size" error (which you get when running this in isolation), instead of the "/dev/foo: already exists in filesystem" which is due to a dirty VM.