Skip to content

nvme: fix copy command nr value as zero based #3323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ikegami-t wants to merge 1 commit into from
+2 −2
Closed

nvme: fix copy command nr value as zero based #3323

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions nvme.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7865,7 +7865,7 @@ static int copy_cmd(int argc, char **argv, struct command *acmd, struct plugin *
nats = argconfig_parse_comma_sep_array_u16(cfg.elbats, elbats,
ARRAY_SIZE(elbats));

nr = max(nb, max(ns, max(nrts, max(natms, nats))));
nr = max(nb, max(ns, max(nrts, max(natms, nats)))) - 1;
if (cfg.format == 2 || cfg.format == 3) {
if (nr != nids) {
nvme_show_error("formats 2 and 3 require source namespace ids for each source range");
Expand All @@ -7875,7 +7875,7 @@ static int copy_cmd(int argc, char **argv, struct command *acmd, struct plugin *
nvme_show_error("formats 0 and 1 do not support cross-namespace copy");
return -EINVAL;
}
if (!nr || nr > 256) {
if (nr > 255) {
nvme_show_error("invalid range");
return -EINVAL;
}
Expand Down
Loading