Skip to content

tests: fix python TypeError errors #3319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ikegami-t wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −2
Open

tests: fix python TypeError errors #3319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions tests/nvme_copy_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@

"""

import base64

from nvme_test import TestNVMe


Expand Down Expand Up @@ -44,12 +46,12 @@ def setUp(self):
self.assertEqual(err, 0, "ERROR : nvme get-feature failed")
self.host_behavior_data = result.stdout
# enable cross-namespace copy formats
if self.host_behavior_data[4] & cross_namespace_copy:
if int.from_bytes(base64.b64decode(self.host_behavior_data[4])) & cross_namespace_copy:
# skip if already enabled
print("Cross-namespace copy already enabled, skipping set-features")
self.host_behavior_data = None
else:
data = self.host_behavior_data[:4] + cross_namespace_copy.to_bytes(2, 'little') + self.host_behavior_data[6:]
data = self.host_behavior_data[:4] + str(cross_namespace_copy.to_bytes(2, 'little')) + self.host_behavior_data[6:]
set_features_cmd = f"{self.nvme_bin} set-feature " + \
f"{self.ctrl} --feature-id=0x16 --data-len=512"
result = self.run_cmd(set_features_cmd, stdin_data=data)
Expand Down
Loading