json: Enables json printing and ocp plugin without fabrics#3318
Open
bgoing-micron-oss wants to merge 1 commit intolinux-nvme:masterfrom
Open
json: Enables json printing and ocp plugin without fabrics#3318bgoing-micron-oss wants to merge 1 commit intolinux-nvme:masterfrom
bgoing-micron-oss wants to merge 1 commit intolinux-nvme:masterfrom
Conversation
Enables non fabrics-specific json functionality like printing and the ocp plugin when json-c is available, even if fabrics is disabled. Only nvme/json.c functionality is excluded when fabrics is disabled. Signed-off-by: Broc Going <[email protected]>
Contributor
Author
|
@igaw We have been testing the ocp plugin and json printing on Windows, which doesn't use fabrics. A recent change disabled json-c when fabrics was disabled, which broke that functionality for us. It looks like only nvme/json.c is fabrics-only, so I made the fabrics dependency only apply to that json support specifically. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables non fabrics-specific json functionality like printing and the ocp plugin when json-c is available, even if fabrics is disabled. Only nvme/json.c functionality is excluded when fabrics is disabled.