Skip to content

python, swig: fix bugs and restore Python ergonomics after libnvmf_context refactor #3291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
martin-belanger wants to merge 3 commits into from
Closed

python, swig: fix bugs and restore Python ergonomics after libnvmf_context refactor #3291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af40e0b
swig: fix Py_NewRef compatibility with Python < 3.10
Apr 20, 2026
1dfe1c0
swig: fix bugs introduced in libnvmf_context refactor
Apr 20, 2026
bda96d0
swig: replace libnvmf_context with dict-based ctrl constructor
Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions libnvme/libnvme/meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,12 @@ if want_python
swig_cmd = [swig, '-python', '-o', '@OUTPUT1@', '@INPUT0@']
endif

py_compat_c_args = []
if not cc.has_header_symbol('Python.h', 'Py_NewRef', dependencies: py3_dep)
warning('Python < 3.10 detected: providing Py_NewRef compatibility shim in nvme.i')
py_compat_c_args = ['-DSWIG_COMPAT_PY_NEWREF']
endif

pymod_swig = custom_target(
'nvme.py',
input: ['nvme.i'],
Expand All @@ -28,6 +34,7 @@ if want_python
pynvme_clib = python3.extension_module(
'_nvme',
nvme_wrap_c,
c_args: py_compat_c_args,
dependencies: [config_dep, ccan_dep, libnvme_dep, py3_dep],
install: true,
subdir: 'libnvme',
Expand Down
Loading
Loading