nvme: refactor NVME_ARGS help text constants#3287
Draft
igaw wants to merge 4 commits intolinux-nvme:masterfrom
Draft
nvme: refactor NVME_ARGS help text constants#3287igaw wants to merge 4 commits intolinux-nvme:masterfrom
igaw wants to merge 4 commits intolinux-nvme:masterfrom
Conversation
igaw
force-pushed
the
global-help-text
branch
3 times, most recently
from
0caf937 to
787cc24
Compare
Move all help text to a central place so it's easy to maintain a consistent documentation and wording. Signed-off-by: Daniel Wagner <[email protected]>
Make it easier to distinguish between commands and argument help text. Signed-off-by: Daniel Wagner <[email protected]>
Use a more consistent language in the help text. Signed-off-by: Daniel Wagner <[email protected]>
Collaborator
Author
|
I am not really sold on this approach. The functions get a bit simpler to skim over but honestly it never really bothered me much. One thing though I do like is the style improvements style etc but we can do this with the functions. Also making the help text consistent isn't that difficult with copilot tbh. Idk. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move all help text to a central place so it's easy to maintain a consistent documentation and wording.
TODO:
For later:
Fixes: #3080