Skip to content

fabrics: issue a warning on invalid traddr format #3260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igaw merged 1 commit into from
Apr 9, 2026
+7 −3
Merged

fabrics: issue a warning on invalid traddr format #3260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions libnvme/src/nvme/fabrics.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1397,7 +1397,8 @@ static int nvme_discovery_log(const struct libnvme_get_discovery_args *args,
return err;
}

static void sanitize_discovery_log_entry(struct nvmf_disc_log_entry *e)
static void sanitize_discovery_log_entry(struct libnvme_global_ctx *ctx,
struct nvmf_disc_log_entry *e)
{
strchomp(e->trsvcid, sizeof(e->trsvcid));
strchomp(e->traddr, sizeof(e->traddr));
Expand All @@ -1409,8 +1410,11 @@ static void sanitize_discovery_log_entry(struct nvmf_disc_log_entry *e)
if (e->trtype == NVMF_TRTYPE_FC) {
char *comma = strchr(e->traddr, ',');

if (comma)
if (comma) {
libnvme_msg(ctx, LOG_WARNING,
"invalid traddr separator ',' instead ':', fixing it");
*comma = ':';
}
}
}

Expand Down Expand Up @@ -1439,7 +1443,7 @@ __public int nvmf_get_discovery_wargs(struct libnvme_get_discovery_args *args,
return err;

for (int i = 0; i < le64_to_cpu(log->numrec); i++)
sanitize_discovery_log_entry(&log->entries[i]);
sanitize_discovery_log_entry(args->c->ctx, &log->entries[i]);

*logp = log;
return 0;
Expand Down
Loading