Skip to content

nvme connect: fix output #3217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igaw merged 2 commits into from
Mar 30, 2026
Merged

nvme connect: fix output #3217

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3712332
fabrics: dump config on stdout
igaw Mar 30, 2026
9308c7b
fabrics: do not print device name when dumping config
igaw Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions fabrics.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ static int setup_common_context(struct nvmf_context *fctx,
struct cb_fabrics_data {
struct nvme_fabrics_config *cfg;
nvme_print_flags_t flags;
bool quiet;
char *raw;
char **argv;
FILE *f;
Expand All @@ -196,6 +197,9 @@ static void cb_connected(struct nvmf_context *fctx,
{
struct cb_fabrics_data *cfd = user_data;

if (cfd->quiet)
return;

if (cfd->flags == NORMAL) {
printf("device: %s\n", nvme_ctrl_get_name(c));
return;
Expand Down Expand Up @@ -659,12 +663,13 @@ int fabrics_connect(const char *desc, int argc, char **argv)
return ret;
}

struct cb_fabrics_data dld = {
struct cb_fabrics_data cfd = {
.flags = flags,
.quiet = dump_config,
.raw = raw,
};
ret = create_common_context(ctx, persistent, &fa,
&cfg, &dld, &fctx);
&cfg, &cfd, &fctx);
if (ret)
return ret;

Expand All @@ -679,7 +684,7 @@ int fabrics_connect(const char *desc, int argc, char **argv)
}

if (dump_config)
nvme_dump_config(ctx, STDERR_FILENO);
nvme_dump_config(ctx, STDOUT_FILENO);

return 0;
}
Expand Down
Loading