util/mem: fix NULL dereference in nvme_realloc() on allocation failure#3175
Closed
jimmunn wants to merge 1 commit intolinux-nvme:masterfrom
Closed
util/mem: fix NULL dereference in nvme_realloc() on allocation failure#3175jimmunn wants to merge 1 commit intolinux-nvme:masterfrom
jimmunn wants to merge 1 commit intolinux-nvme:masterfrom
Conversation
bbusacker
approved these changes
Mar 12, 2026
If nvme_alloc() fails and returns NULL, the subsequent memcpy() would dereference a NULL pointer, resulting in undefined behavior. Add a NULL check on the result of nvme_alloc() and return NULL early, consistent with standard realloc() semantics where the original pointer remains valid on failure. Signed-off-by: Jim Munn <[email protected]>
jimmunn
force-pushed
the
bugfix/nvme_realloc-fix
branch
from
6099f9d to
24ced30
Compare
Contributor
Author
|
Had wrong author info in commit. Closing and recreating. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If nvme_alloc() fails and returns NULL, the subsequent memcpy() would dereference a NULL pointer, resulting in undefined behavior. Add a NULL check on the result of nvme_alloc() and return NULL early, consistent with standard realloc() semantics where the original pointer remains valid on failure.