generate-accessors: make accessor naming convention configurable#3167
Closed
martin-belanger wants to merge 1 commit intolinux-nvme:masterfrom
Closed
generate-accessors: make accessor naming convention configurable#3167martin-belanger wants to merge 1 commit intolinux-nvme:masterfrom
martin-belanger wants to merge 1 commit intolinux-nvme:masterfrom
Conversation
Replace hardcoded "%s%s_%s_get/set" format strings with SET_FMT/GET_FMT macros controlled by the SET_GET_AT_THE_END compile-time flag, allowing easy switching between nvme_foo_get()/nvme_foo_set() and nvme_get_foo()/nvme_set_foo() naming styles. Also fix a handful of comment issues. Signed-off-by: Martin Belanger <[email protected]>
Author
|
Disregard this PR. Will submit a separate one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace hardcoded "%s%s_%s_get/set" format strings with SET_FMT/GET_FMT macros controlled by the SET_GET_AT_THE_END compile-time flag, allowing easy switching between nvme_foo_get()/nvme_foo_set() and nvme_get_foo()/nvme_set_foo() naming styles.
Also fix a handful of comment issues.