Skip to content

build: add Fedora and Tubmleweed to the build matrix #3143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igaw merged 3 commits into from
Mar 10, 2026
+9 −5
Merged

build: add Fedora and Tubmleweed to the build matrix #3143

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c7ec53
build: add Fedora and Tubmleweed to the build matrix
igaw Mar 9, 2026
1926e7d
mi: verify length of data before reading header
igaw Mar 9, 2026
d8d7b31
misc: initialize memory before using in tests
igaw Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,11 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
distro: [debian, fedora, tumbleweed]
compiler: [gcc, clang]
buildtype: [debug, release]
container:
image: ghcr.io/linux-nvme/debian:latest
image: ghcr.io/linux-nvme/${{ matrix.distro }}:latest
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- name: Mark repo as safe for git
Expand All @@ -37,10 +38,11 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
compiler: [gcc, clang]
buildtype: [debug, release]
distro: [debian]
compiler: [gcc]
buildtype: [release]
container:
image: ghcr.io/linux-nvme/debian:latest
image: ghcr.io/linux-nvme/${{ matrix.distro }}:latest
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- name: Mark repo as safe for git
Expand Down
2 changes: 2 additions & 0 deletions libnvme/src/nvme/mi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1440,6 +1440,8 @@ void nvme_mi_aem_aeolli_set_aeoltl(struct nvme_mi_aem_occ_list_hdr *hdr, __u32 a

static int validate_enabled_list(struct nvme_mi_aem_supported_list *list, size_t len)
{
if (len < sizeof(struct nvme_mi_aem_supported_list))
return -EPROTO;
Copy link
Copy Markdown
Collaborator Author

@igaw igaw Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jk-ozlabs is this correct?

Copy link
Copy Markdown
Collaborator

@jk-ozlabs jk-ozlabs Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

This is @chorkin 's area, so might be good to get his input too.

Copy link
Copy Markdown
Contributor

@chorkin chorkin Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Copy Markdown
Collaborator Author

@igaw igaw Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

if (list->hdr.aeslver != 0)
return -EPROTO;
if (list->hdr.aeslhl != sizeof(struct nvme_mi_aem_supported_list))
Expand Down