Skip to content

Set/update SPDX and Copyright statements#3138

Merged
igaw merged 7 commits intolinux-nvme:masterfrom
igaw:licenses
Mar 10, 2026
Merged

Set/update SPDX and Copyright statements#3138
igaw merged 7 commits intolinux-nvme:masterfrom
igaw:licenses

Conversation

@igaw
Copy link
Copy Markdown
Collaborator

@igaw igaw commented Mar 9, 2026

Update and/or set the SPDX tag and, where possible, also the copyright statement.

I've used reuse to identify files that are missing the SPDX tag and copyright statements and updated them where it was clear how to do so. I asked Hannes and Martin in advance whether they were okay with changing licenses. This involves either changing GPL to LGPL or replacing Apache with GPL/LGPL. Both gave me their approval.

This work is not complete. There are still many files missing copyright statements, and it is not clear what to do in those cases. I think I could ask the original authors if they could provide them (e.g., Jeremy, Margin B., ...), but I am not sure how to proceed with all those files from Keith when he was still at Intel.

Another question I have is what to do with all the documentation (Documentation and libnvme/doc). I am not sure what the original intended license is. If I understand correctly, it may not be wise to release them under GPL or LGPL. The GNU project provides specific licenses intended for documentation.

@hreinecke
@jk-ozlabs
@martin-belanger
@keithbusch

igaw added 7 commits March 9, 2026 11:42
This license doesn't exist yet. The current latest version is
LGPL-2.1-or-later.

Signed-off-by: Hannes Reinecke <[email protected]>
Signed-off-by: Daniel Wagner <[email protected]>
This is supposed to be license under GPL-2.0-or-later. Update it
accordingly.

Signed-off-by: Daniel Wagner <[email protected]>
Update the license to match the project license.

Signed-off-by: Daniel Wagner <[email protected]>
The libnvme license is LGPL-2.1-or-later, update the only Apache-2.0
user left.

Signed-off-by: Martin Belanger <[email protected]>
Signed-off-by: Hannes Reinecke <[email protected]>
Signed-off-by: Daniel Wagner <[email protected]>
Add the spdx tag and where possible the copyright statement.

Signed-off-by: Daniel Wagner <[email protected]>
Add/move all licenses used in the project into one place. 'reuse lint'
reports various missing license texts.

ccan: used compared the original license text with wdiff to ensure it's
the same license text.

Signed-off-by: Daniel Wagner <[email protected]>
Apparently, the European Cyber Resilience Act (CRA) mandates that Open
Source project document where security reports can be sent to.

Signed-off-by: Daniel Wagner <[email protected]>
@jk-ozlabs
Copy link
Copy Markdown
Collaborator

I think I could ask the original authors if they could provide them (e.g., Jeremy, Margin B., ...)

Yes, absolutely fine here. The mi*.[ch] files should have existing copyright notices (and I am fine to replace those with SPDX equivalents), but let me know whether you need additional headers/SPDX tags elsewhere too.

@igaw
Copy link
Copy Markdown
Collaborator Author

igaw commented Mar 10, 2026

I think I could ask the original authors if they could provide them (e.g., Jeremy, Margin B., ...)

Yes, absolutely fine here. The mi*.[ch] files should have existing copyright notices (and I am fine to replace those with SPDX equivalents), but let me know whether you need additional headers/SPDX tags elsewhere too.

Apparently, all files are supposed to have a SPDX tag and and a copyright statement. I added to most of the files with the SPDX tag. The copyright statement is a bit more tricky. I'll prepare a PR with something like

// SPDX-License-Identifier: LGPL-2.1-or-later
/*
 * This file is part of libnvme.
 * Copyright (c) 2026 Code Construct Pty Ltd.
 *
 * Authors: Jeremy Kerr <[email protected]>
 */

those file which you have created and no copyright statement if this is okay.

@igaw igaw merged commit c0d8d44 into linux-nvme:master Mar 10, 2026
20 of 21 checks passed
@igaw igaw deleted the licenses branch March 10, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants