Skip to content

mi: fix nvme_mi_create_global_ctx removal #3131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igaw merged 1 commit into from
Mar 4, 2026
Merged

mi: fix nvme_mi_create_global_ctx removal #3131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libnvme/examples/mi-conf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ int main(int argc, char **argv)
if (rc)
errx(EXIT_FAILURE, "can't parse MI device string '%s'", devstr);

ctx = nvme_mi_create_global_ctx(stderr, DEFAULT_LOGLEVEL);
ctx = nvme_create_global_ctx(stderr, DEFAULT_LOGLEVEL);
if (!ctx)
err(EXIT_FAILURE, "can't create global context");

Expand Down Expand Up @@ -219,7 +219,7 @@ int main(int argc, char **argv)
dbus_error_free(&berr);
nvme_mi_close(ep);
out_free_ctx:
nvme_mi_free_global_ctx(ctx);
nvme_free_global_ctx(ctx);

return rc ? EXIT_FAILURE : EXIT_SUCCESS;
}
Expand Down
2 changes: 0 additions & 2 deletions libnvme/src/libnvme.ld
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,14 +132,12 @@ LIBNVME_2_0 {
nvme_mi_close;
nvme_mi_close_transport_handle;
nvme_mi_control;
nvme_mi_create_global_ctx;
nvme_mi_ctrl_id;
nvme_mi_endpoint_desc;
nvme_mi_ep_get_timeout;
nvme_mi_ep_set_timeout;
nvme_mi_first_ctrl;
nvme_mi_first_endpoint;
nvme_mi_free_global_ctx;
nvme_mi_init_transport_handle;
nvme_mi_mi_config_get;
nvme_mi_mi_config_set;
Expand Down
4 changes: 2 additions & 2 deletions libnvme/src/nvme/mi-mctp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -954,7 +954,7 @@ struct nvme_global_ctx *nvme_mi_scan_mctp(void)
dbus_bool_t drc;
DBusError berr;

ctx = nvme_mi_create_global_ctx(NULL, DEFAULT_LOGLEVEL);
ctx = nvme_create_global_ctx(NULL, DEFAULT_LOGLEVEL);
if (!ctx) {
errno = ENOMEM;
return NULL;
Expand Down Expand Up @@ -1028,7 +1028,7 @@ struct nvme_global_ctx *nvme_mi_scan_mctp(void)

if (rc < 0) {
if (ctx) {
nvme_mi_free_global_ctx(ctx);
nvme_free_global_ctx(ctx);
}
errno = errno_save;
ctx = NULL;
Expand Down