nvme: fix segfault at nvme_match_devname()#3125
Merged
igaw merged 1 commit intolinux-nvme:masterfrom Mar 3, 2026
Merged
Conversation
Passing the character device as an argument to nvme list-subsys can result in a segfault at nvme_match_devname() as seen in the below gdb stack trace: (gdb) where nvme_ctrl_get_name (c=0x0) at ../libnvme/src/nvme/tree.c:1085 0x000000000040e800 in nvme_match_devname (devname=0xf910df0 "0\342\220\017", ns=0x7ffd1ed57703) at ../nvme.c:3462 0x000000000040e853 in nvme_match_device_filter (s=0x0, c=0xf90dbe0, ns=0x0, f_args=0x30) at ../nvme.c:3471 (gdb) This is because nvme_ns_get_ctrl() can return a NULL for multipathed ns devices. Fix the same. Fixes: 51bc794 ("nvme: allow char dev filter for show-topology and list-subsys commands") Signed-off-by: Martin George <[email protected]>
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing the character device as an argument to nvme list-subsys can result in a segfault at nvme_match_devname() as seen in the below gdb stack trace:
(gdb) where
nvme_ctrl_get_name (c=0x0) at ../libnvme/src/nvme/tree.c:1085 0x000000000040e800 in nvme_match_devname (devname=0xf910df0 "0\342\220\017", ns=0x7ffd1ed57703) at ../nvme.c:3462 0x000000000040e853 in nvme_match_device_filter (s=0x0, c=0xf90dbe0, ns=0x0, f_args=0x30) at ../nvme.c:3471 (gdb)
This is because nvme_ns_get_ctrl() can return a NULL for multipathed ns devices. Fix the same.
Fixes: 51bc794 ("nvme: allow char dev filter for show-topology and list-subsys commands")