Skip to content

fabrics: add additional debug messages for --tls and --concat #3069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igaw merged 1 commit into from
Jan 21, 2026
Merged

fabrics: add additional debug messages for --tls and --concat #3069

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions libnvme/src/nvme/fabrics.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1209,10 +1209,15 @@

if (e->trtype == NVMF_TRTYPE_TCP &&
e->tsas.tcp.sectype != NVMF_TCP_SECTYPE_NONE) {
if (e->treq & NVMF_TREQ_REQUIRED)
if (e->treq & NVMF_TREQ_REQUIRED) {
nvme_msg(h->ctx, LOG_DEBUG, "setting --tls due to treq %s and sectype %s\n",

Check failure on line 1213 in libnvme/src/nvme/fabrics.c

View workflow job for this annotation

GitHub Actions / checkpatch review 

WARNING: line length of 100 exceeds 80 columns
nvmf_treq_str(e->treq), nvmf_sectype_str(e->tsas.tcp.sectype));

Check failure on line 1214 in libnvme/src/nvme/fabrics.c

View workflow job for this annotation

GitHub Actions / checkpatch review 

WARNING: line length of 103 exceeds 80 columns
c->cfg.tls = true;
else if (e->treq & NVMF_TREQ_NOT_REQUIRED)
} else if (e->treq & NVMF_TREQ_NOT_REQUIRED) {
nvme_msg(h->ctx, LOG_DEBUG, "setting --concat due to treq %s and sectype %s\n",

Check failure on line 1217 in libnvme/src/nvme/fabrics.c

View workflow job for this annotation

GitHub Actions / checkpatch review 

WARNING: line length of 103 exceeds 80 columns
nvmf_treq_str(e->treq), nvmf_sectype_str(e->tsas.tcp.sectype));

Check failure on line 1218 in libnvme/src/nvme/fabrics.c

View workflow job for this annotation

GitHub Actions / checkpatch review 

WARNING: line length of 103 exceeds 80 columns
c->cfg.concat = true;
}
}

ret = nvmf_add_ctrl(h, c, cfg);
Expand Down