Merged
Conversation
Move all symbols into the 2.0 section. Signed-off-by: Daniel Wagner <[email protected]>
The commom name for linker scripts uses the .ld extension, thus rename the libnvme.map to libnvme.ld Signed-off-by: Daniel Wagner <[email protected]>
When debugging it's useful to get the exact command line which is used. This string can then be directly given to 'gdb --args'. Signed-off-by: Daniel Wagner <[email protected]>
nvme_update_config is used to dump the current configuration to the either stdout or a config file. There is also nvme_dump_config which does almost the same thing. The only difference is that nvme_update_config is testing if the something has been modified. The modified tracking happens on a global level and almost all operations on the tree will set the modified flag. This is actually not really needed. nvme-cli uses for the 'config' command which expects that the config is updated. One could argue that the config should not be written when nothing changes. But this could be done in a different way, e.g. create a temp config and compare it to the original and only overwrite the original if something changes. But no one complained that the config is overwritten all the time so far (remember the modified flag is almost certainly always set). Signed-off-by: Daniel Wagner <[email protected]>
Follow the same order for describing the fabrics configuration. This will make is simpler to replace fabrics_args with nvmf_context. While at it also fix the assignments alignment. Signed-off-by: Daniel Wagner <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few cleanups as result from workong on adding
struct nvme_global_ctxto the API.