nvme: refactor PI tagging for uniform behavior#2983
Conversation
07119fe to
76239bf
Compare
|
@igaw Not sure how to address the check patch warnings about the exceeding char limit. I tried to fit the changes to the surrounding codebase. |
|
Just ingore those checkpatch warnings. It's just a stupid reporting tool and we should not blindly follow it. Your changes look good to me. The only thing I would probably change is the overlong lines for the function definition. |
|
Would you mind to rebase it to the current master. Due the passthru updates some changes are necessary, though it should be fairly simple :) |
Introduce `init_pi_tags` helper function that is called for all IO commands, to ensure uniform behavior. Renaming related variables to match the spec. Signed-off-by: Dennis Maisenbacher <[email protected]>
76239bf to
4734acf
Compare
|
Done :) The rebase even discovered a bug in |
|
Yeah, type casts have always a bit of a smell. Nice, thanks! |
Introduce
init_pi_tagshelper function that is called for all IO commands, to ensure uniform behavior.Renaming related variables to match the spec.