plugins/sandisk: Use Correct PCI Vendor ID for SNESSD1 Drives#2968
Closed
jeff-lien-sndk wants to merge 1 commit intolinux-nvme:masterfrom
Closed
plugins/sandisk: Use Correct PCI Vendor ID for SNESSD1 Drives#2968jeff-lien-sndk wants to merge 1 commit intolinux-nvme:masterfrom
jeff-lien-sndk wants to merge 1 commit intolinux-nvme:masterfrom
Conversation
The current Sandisk plugin code is using the Western Digital PCI vendor id for the SNESSD1 drives. It should be using the Sandisk Vendor ID (0x15B7) instead. The wdc plugin code also needs to be updated to recognize this new Sandisk device. Signed-off-by: jeff-lien-sndk <[email protected]> Reviewed-by: brandon-paupore-sndk <[email protected]>
Contributor
Author
|
@igaw Dan, could your review and merge this PR today if possible? Thanks |
Contributor
Author
|
Closed - replaced with PR #2970 which includes one additional minor fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current Sandisk plugin code is using the Western Digital PCI vendor id for the SNESSD1 drives. It should be using the Sandisk Vendor ID (0x15B7) instead. The wdc plugin code also needs to be updated to recognize this new Sandisk device.