Skip to content

nvme: update the tls 'compat' option documentation #2932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igaw merged 1 commit into from
Oct 13, 2025
Merged

nvme: update the tls 'compat' option documentation #2932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Documentation/nvme-check-tls-key.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ OPTIONS

-C:
--compat:
Use the original algorithm when deriving TLS keys for
compatibility with older implentations.
Use the original non-RFC 8446 compliant algorithm when
checking TLS keys for compatibility with older implentations.

-f <keyfile>
--keyfile=<keyfile>
Expand Down
4 changes: 2 additions & 2 deletions nvme.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9769,7 +9769,7 @@
const char *keytype = "Key type of the retained key.";
const char *insert = "Insert retained key into the keyring.";
const char *keyfile = "Update key file with the derive TLS PSK.";
const char *compat = "Use compatibility algorithm for HKDF-Expand-Label.";
const char *compat = "Use non-RFC 8446 compliant algorithm for deriving TLS PSK for older implementations";

Check failure on line 9772 in nvme.c

View workflow job for this annotation

GitHub Actions / checkpatch review 

WARNING: line length of 115 exceeds 100 columns

_cleanup_free_ unsigned char *raw_secret = NULL;
_cleanup_free_ char *encoded_key = NULL;
Expand Down Expand Up @@ -9913,7 +9913,7 @@
const char *keytype = "Key type of the retained key.";
const char *insert = "Insert retained key into the keyring.";
const char *keyfile = "Update key file with the derive TLS PSK.";
const char *compat = "Use compatibility algorithm for HKDF-Expand-Label.";
const char *compat = "Use non-RFC 8446 compliant algorithm for checking TLS PSK for older implementations.";

Check failure on line 9916 in nvme.c

View workflow job for this annotation

GitHub Actions / checkpatch review 

WARNING: line length of 116 exceeds 100 columns

_cleanup_free_ unsigned char *decoded_key = NULL;
_cleanup_free_ char *hnqn = NULL;
Expand Down