Skip to content

ocp: Update completions for ocp internal-log and telemetry-string-log #2902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igaw merged 1 commit into from
Aug 29, 2025
Merged

ocp: Update completions for ocp internal-log and telemetry-string-log #2902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions completions/_nvme
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,16 +194,16 @@ _nvme () {
/dev/nvme':supply a device to use (required)'
--telemetry-type=':Telemetry Type; host, host0, host1 or controller generated'
-t':alias for --telemetry-type'
--data-area=':Telemetry Data Area; 1 or 2'
--data-area=':Telemetry Data Area; 1, 2, 3, or 4'
-a':alias for --data-area'
--output-file=':Output file name with path'
-o':alias for --output-file'
-f':alias for --output-file'
--telemetry-log=':Telemetry log binary'
-l':alias for --telemetry-log'
--string-log=':String log binary'
-s':alias for --string-log'
--output-format':Output format: normal|json'
-f':alias for --output-format'
-o':alias for --output-format'
)
_arguments '*:: :->subcmds'
_describe -t commands "nvme ocp internal-log options" _internal_log
Expand Down Expand Up @@ -296,8 +296,10 @@ _nvme () {
local _telemetry_string_log
_telemetry_string_log=(
/dev/nvme':supply a device to use (required)'
--output-format=':Output format: normal|json|binary'
-o':alias for --output-format'
--output-file=':Output file name with path'
-o':alias for --output-file'
-f':alias for --output-file'
)
_arguments '*:: :->subcmds'
_describe -t commands "nvme ocp telemetry-string-log options" _telemetry_string_log
Expand Down
4 changes: 2 additions & 2 deletions completions/bash-nvme-completion.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1598,7 +1598,7 @@ plugin_ocp_opts () {
;;
"internal-log")
opts+=" --telemetry-log= -l --string-log= -s \
--output-file= -o --output-format= -f \
--output-file= -f --output-format= -o \
--data-area= -a --telemetry-type= -t"
;;
"clear-fw-activate-history")
Expand All @@ -1623,7 +1623,7 @@ plugin_ocp_opts () {
opts+=" --sel= -S --all -a --no-uuid -n"
;;
"telemetry-string-log")
opts+=" --output-file= -o"
opts+=" --output-file= -f --output-format= -o"
;;
"set-telemetry-profile")
opts+=" --telemetry-profile-select= -t"
Expand Down