build: replace AppImage with static build binary#2884
Merged
igaw merged 1 commit intolinux-nvme:masterfrom Jul 29, 2025
Merged
Conversation
igaw
reviewed
Jul 29, 2025
igaw
reviewed
Jul 29, 2025
| echo "VERSION=${VERSION}" >> $GITHUB_OUTPUT | ||
| echo $VERSION | ||
|
|
||
| make static |
The AppImage build was introduced to give users access to a test binary. Before the switch to meson, the static build was used for this. In the meantime we figured out how to build a static build with meson, so there is no need for the AppImage workflow. Start to add to the release versions of nvme the tag as postfix. Furthermore, upload the artifacts to github. Signed-off-by: Daniel Wagner <[email protected]> Co-authored-by: Dennis Maisenbacher <[email protected]>
Collaborator
|
Thanks a lot. Let's see if all works nicely. |
Contributor
Author
|
From the build log in https://github.com/linux-nvme/nvme-cli/actions/runs/16595459723/job/46940875602: |
Collaborator
|
well there isn't much we can do, either disable the openssl support or irngore this error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AppImage build was introduced to give users access to a test binary. Before the switch to meson, the static build was used for this. In the meantime we figured out how to build a static build with meson, so there is no need for the AppImage workflow.
Start to add to the release versions of nvme the tag as postfix. Furthermore, upload the artifacts to github.
Fixes: #2876 #2398