Skip to content

nvme-print: include subsys serial num in the list-subsys output #2799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igaw merged 2 commits into from
May 8, 2025
Merged

nvme-print: include subsys serial num in the list-subsys output #2799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d8471f
build: bump libnvme wrap
martin-gpy May 7, 2025
53d321d
nvme-print: display serial num in list-subsys output
martin-gpy May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions nvme-print-json.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2543,6 +2543,8 @@ static void json_print_nvme_subsystem_list(nvme_root_t r, bool show_ana)
if (json_print_ops.flags & VERBOSE) {
obj_add_str(subsystem_attrs, "Model",
nvme_subsystem_get_model(s));
obj_add_str(subsystem_attrs, "Serial",
nvme_subsystem_get_serial(s));
obj_add_str(subsystem_attrs, "Firmware",
nvme_subsystem_get_fw_rev(s));
obj_add_str(subsystem_attrs, "IOPolicy",
Expand Down Expand Up @@ -4575,6 +4577,8 @@ static void json_simple_topology(nvme_root_t r)
if (json_print_ops.flags & VERBOSE) {
obj_add_str(subsystem_attrs, "Model",
nvme_subsystem_get_model(s));
obj_add_str(subsystem_attrs, "Serial",
nvme_subsystem_get_serial(s));
obj_add_str(subsystem_attrs, "Firmware",
nvme_subsystem_get_fw_rev(s));
obj_add_str(subsystem_attrs, "IOPolicy",
Expand Down
2 changes: 2 additions & 0 deletions nvme-print-stdout.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1114,6 +1114,8 @@ static void stdout_subsys_config(nvme_subsystem_t s)
if (stdout_print_ops.flags & VERBOSE) {
printf("%*s model=%s\n", len, " ",
nvme_subsystem_get_model(s));
printf("%*s serial=%s\n", len, " ",
nvme_subsystem_get_serial(s));
printf("%*s firmware=%s\n", len, " ",
nvme_subsystem_get_fw_rev(s));
printf("%*s iopolicy=%s\n", len, " ",
Expand Down
2 changes: 1 addition & 1 deletion subprojects/libnvme.wrap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[wrap-git]
url = https://github.com/linux-nvme/libnvme.git
revision = ef4df90bf674abb9ee5cd7560c5e92c8705e2c3b
revision = 81bd404245823763121278fdd5f01c8177e81218

[provide]
libnvme = libnvme_dep
Expand Down