Moved O_BINARY handling to the one place it is used.

Author: bgoing-micron-oss

libnvme/src/platform/linux.h

@@ -12,10 +12,5 @@ typedef int libnvme_fd_t;
 #define TEST_FD 0xFD
 #define INIT_FD -1
 
-/* O_BINARY is required on Windows, but not defined on Linux. */
-#ifndef O_BINARY
-#define O_BINARY 0
-#endif
-
 /* Platform initialization - no-op on Linux */
 static inline void libnvme_init(void) {}

plugins/ocp/ocp-nvme.c

@@ -1188,7 +1188,11 @@ static int get_telemetry_log_page_data(struct libnvme_transport_handle *hdl,
 	}
 	memset(hdr, 0, bs);
 
+#ifdef O_BINARY	/* required for Windows, not defined on Linux */
 	fd = open(output_file, O_WRONLY | O_CREAT | O_TRUNC | O_BINARY, 0666);
+#else
+	fd = open(output_file, O_WRONLY | O_CREAT | O_TRUNC, 0666);
+#endif
 	if (fd < 0) {
 		fprintf(stderr, "Failed to open output file %s: %s!\n",
 				output_file, libnvme_strerror(errno));