Skip to content

Commit 8540f32

Browse files
Minimized includes in windows.h and linux.h
- Removed unneeded includes. - Added gethostname support to nvme/unistd.h
1 parent d6adc8d commit 8540f32

4 files changed

Lines changed: 7 additions & 36 deletions

File tree

libnvme/src/nvme/unistd.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,9 @@
1717

1818
#if defined(_WIN32) || defined(_WIN64)
1919

20+
#define WIN32_LEAN_AND_MEAN /* keeps windows.h from including winsock.*/
21+
#include <winsock2.h> /* for gethostname */
22+
2023
#include <sysinfoapi.h>
2124

2225
/* unistd.h POSIX compatibility */

libnvme/src/nvme/util.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@
3333
#include <ccan/endian/endian.h>
3434
#include <ccan/minmax/minmax.h>
3535

36+
#include <nvme/unistd.h>
37+
3638
#include <libnvme.h>
3739

3840
#include "cleanup.h"

libnvme/src/platform/linux.h

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -8,29 +8,6 @@
88

99
#pragma once
1010

11-
/* Linux-specific includes */
12-
#include <dirent.h>
13-
#include <endian.h>
14-
#include <errno.h>
15-
#include <fcntl.h>
16-
#include <poll.h>
17-
#include <stdlib.h>
18-
#include <unistd.h>
19-
20-
#include <syslog.h>
21-
#include <sys/ioctl.h>
22-
#include <sys/mman.h>
23-
#include <sys/param.h>
24-
#include <sys/socket.h>
25-
#include <sys/stat.h>
26-
#include <sys/uio.h>
27-
28-
#include <arpa/inet.h>
29-
#include <ifaddrs.h>
30-
#include <netdb.h>
31-
#include <netinet/in.h>
32-
33-
3411
typedef int libnvme_fd_t;
3512
#define TEST_FD 0xFD
3613
#define INIT_FD -1

libnvme/src/platform/windows.h

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -8,23 +8,12 @@
88

99
#pragma once
1010

11-
/* Windows-specific includes - winsock2 before windows.h to avoid warnings */
12-
#define WIN32_LEAN_AND_MEAN
13-
#include <winsock2.h>
14-
#include <ws2tcpip.h>
11+
/* Windows-specific includes */
12+
#define WIN32_LEAN_AND_MEAN /* keeps windows.h from including winsock.*/
1513
#include <windows.h>
16-
#undef WIN32_LEAN_AND_MEAN
1714

18-
#include <bcrypt.h>
19-
#include <direct.h>
20-
#include <errno.h>
2115
#include <fcntl.h>
22-
#include <io.h>
23-
#include <process.h>
24-
#include <signal.h>
2516
#include <stdio.h>
26-
#include <sys/stat.h>
27-
#include <time.h>
2817

2918

3019
/* Platform compatibility helper types and methods */

0 commit comments

Comments
 (0)