Skip to content

types: Fix Live Migration SEQIND Shift and Mask#986

Merged
igaw merged 1 commit intolinux-nvme:masterfrom
DanceDance:fix-lm-seqind
Apr 8, 2025
Merged

types: Fix Live Migration SEQIND Shift and Mask#986
igaw merged 1 commit intolinux-nvme:masterfrom
DanceDance:fix-lm-seqind

Conversation

@DanceDance
Copy link
Copy Markdown
Contributor

@DanceDance DanceDance commented Apr 8, 2025

This change fixes Sequence Indicator (SEQIND) Shift and Mask to match the NVM Express Base Specification, Revision 2.1.

The Mask and Shift are defined relative to Mos:

 * @NVME_LM_SEQIND_SHIFT:			Shift amount to set Sequence Indicator (SEQIND)
 *						field relative to MOS
 * @NVME_LM_SEQIND_MASK:			Mask to set SEQIND field relative to MOS

Relative to Mos, the SHIFT should be 0 and MASK should be 0b11 (0x3).
Screenshot 2025-04-08 at 20 32 07

This change fixes Sequence Indicator (SEQIND) Shift and Mask to match
the NVM Express Base Specification, Revision 2.1.

Signed-off-by: Dmitry Sherstoboev <[email protected]>
@igaw igaw merged commit 56ca8b4 into linux-nvme:master Apr 8, 2025
12 checks passed
@igaw
Copy link
Copy Markdown
Collaborator

igaw commented Apr 8, 2025

Thanks!

@DanceDance DanceDance deleted the fix-lm-seqind branch April 8, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants