types: add performance attribute structures#971
Merged
igaw merged 4 commits intolinux-nvme:masterfrom Apr 7, 2025
Merged
Conversation
igaw
reviewed
Apr 1, 2025
igaw
reviewed
Apr 1, 2025
igaw
reviewed
Apr 1, 2025
| * @vs: Vendor specific | ||
| */ | ||
| struct nvme_vs_perf_attr { | ||
| struct nvme_perf_attr_id paid; |
Collaborator
There was a problem hiding this comment.
Are you sure we want to model it this way? From the spec I would just use __u8 paid[NVME_UUID_LEN] directly.
Should nvme_perf_attr_id exist as it is not really directly as data struct defined in the spec? I'd like to stick as close as possible to the spec and don't come up with our own data structs. While I agree in this case here it would make sense (and it is cleaner), I think it would be better to stick to the spec.
I can be convinced to do add it though. Thoughts? @keithbusch
Contributor
Author
|
Fixed the review comments and rebased but the UUID changes still remained for the build error as mentioned. Thank you. |
These for the performance characteristics feature: 1Ch. Signed-off-by: Tokunori Ikegami <[email protected]>
The feature command dword 11 shifts and masks values. Signed-off-by: Tokunori Ikegami <[email protected]>
Decodes the feature command dword 11 fields values. Signed-off-by: Tokunori Ikegami <[email protected]>
The attribute type shifts and masks values. Signed-off-by: Tokunori Ikegami <[email protected]>
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These for the performance characteristics feature: 1Ch.