Merged
Conversation
The check for existing controller is inverted. Signed-off-by: Hannes Reinecke <[email protected]>
hreinecke
force-pushed
the
py-discovery
branch
from
c2794b8 to
563092f
Compare
Collaborator
|
Shouldn't the example go into the |
Update subsystem definitions to include all attributes from the underlying structure. Signed-off-by: Hannes Reinecke <[email protected]>
Update the discovery-loop.py example to use the tcp transport and fix an issue where the controller wasn't disconnected when the disovery failed. Signed-off-by: Hannes Reinecke <[email protected]>
hreinecke
force-pushed
the
py-discovery
branch
from
3a1025e to
336f5b8
Compare
Collaborator
Author
You are right. Fixed now. |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a rather stupid typo in nvme:discover, and to ensure we catch similar issues going forward I've also added a python discovery script.