Skip to content

mi: nvme_mi_mi_xfer() is overly restrictive #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igaw merged 1 commit into from
Jun 27, 2025
Merged

mi: nvme_mi_mi_xfer() is overly restrictive #1027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions src/nvme/mi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1742,19 +1742,6 @@ int nvme_mi_mi_xfer(nvme_mi_ep_t ep,
return -1;
}

/* request and response lengths & offset must be aligned */
if ((req_data_size & 0x3) ||
(*resp_data_size & 0x3)) {
errno = EINVAL;
return -1;
}

/* bidirectional not permitted */
if (req_data_size && *resp_data_size) {
errno = EINVAL;
return -1;
}

mi_req->hdr.type = NVME_MI_MSGTYPE_NVME;
mi_req->hdr.nmp = (NVME_MI_ROR_REQ << 7) |
(NVME_MI_MT_MI << 3) |
Expand Down
16 changes: 0 additions & 16 deletions test/mi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,26 +649,10 @@ static void test_mi_invalid_formats(nvme_mi_ep_t ep)
ctrl = nvme_mi_init_ctrl(ep, 1);
assert(ctrl);

/* unaligned req size */
len = 0;

rc = nvme_mi_mi_xfer(ep, &req.hdr, 1, &resp, &len);
assert(rc != 0);

/* unaligned resp size */
len = 1;
rc = nvme_mi_mi_xfer(ep, &req.hdr, 0, &resp, &len);
assert(rc != 0);

/* resp too large */
len = 4096 + 4;
rc = nvme_mi_mi_xfer(ep, &req.hdr, 0, &resp, &len);
assert(rc != 0);

/* req and resp payloads */
len = 4;
rc = nvme_mi_mi_xfer(ep, &req.hdr, 4, &resp, &len);
assert(rc != 0);
}

/* test: header length too small */
Expand Down