types: Fix nvme_ns_id_desc packing.#1026
Merged
igaw merged 1 commit intolinux-nvme:masterfrom Jun 26, 2025
Merged
Conversation
Collaborator
|
Why should the length field value change the outer alignment of the data struct? Adding the |
Contributor
Author
|
The namespace identifiers are returned in one contiguous buffer. Even if the main buffer is aligned, when there is one odd length nvme_ns_id_desc within that buffer, it will throw off the alignment of the subsequent nvme_ns_id_desc structures. An example of this is the QEMU NVMe device which returns a CSI identifier that is of length 1. |
Collaborator
|
Ah I see, this is actually describing the wire format and thus there is no alignment.
|
The namespace identifier length (nidl) field can be any length which could potentially lead to unaligned access. Signed-off-by: Thieu Le <[email protected]>
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The namespace identifier length (nidl) field can be any length which could potentially lead to unaligned access.
Signed-off-by: Thieu Le [email protected]