Skip to content

ioctl: only use io_uring for char devices #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igaw merged 1 commit into from
May 28, 2025
Merged

ioctl: only use io_uring for char devices #1018

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/nvme/ioctl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,10 +452,16 @@ int nvme_get_log_page(int fd, __u32 xfer_len, struct nvme_get_log_args *args)
#ifdef CONFIG_LIBURING
int n = 0;
struct io_uring ring;
struct stat st;
bool use_uring = false;

if (io_uring_kernel_support == IO_URING_AVAILABLE) {
if (nvme_uring_cmd_setup(&ring))
return -1;
if (fstat(fd, &st) == 0 && S_ISCHR(st.st_mode)) {
use_uring = true;

if (nvme_uring_cmd_setup(&ring))
return -1;
}
}
#endif
/*
Expand All @@ -477,7 +483,7 @@ int nvme_get_log_page(int fd, __u32 xfer_len, struct nvme_get_log_args *args)
args->log = ptr;
args->rae = offset + xfer < data_len || retain;
#ifdef CONFIG_LIBURING
if (io_uring_kernel_support == IO_URING_AVAILABLE) {
if (io_uring_kernel_support == IO_URING_AVAILABLE && use_uring) {
if (n >= NVME_URING_ENTRIES) {
ret = nvme_uring_cmd_wait_complete(&ring, n);
n = 0;
Expand All @@ -498,7 +504,7 @@ int nvme_get_log_page(int fd, __u32 xfer_len, struct nvme_get_log_args *args)
} while (offset < data_len);

#ifdef CONFIG_LIBURING
if (io_uring_kernel_support == IO_URING_AVAILABLE) {
if (io_uring_kernel_support == IO_URING_AVAILABLE && use_uring) {
ret = nvme_uring_cmd_wait_complete(&ring, n);
nvme_uring_cmd_exit(&ring);
if (ret)
Expand Down