tree: handle the case when host_iface/host_traddr are set to "none"#1015
Merged
igaw merged 1 commit intolinux-nvme:masterfrom May 23, 2025
Merged
tree: handle the case when host_iface/host_traddr are set to "none"#1015igaw merged 1 commit intolinux-nvme:masterfrom
igaw merged 1 commit intolinux-nvme:masterfrom
Conversation
When trying to determine if a candidate configuration matches an existing controller connection, treat the candidate's host_iface or host_traddr set to "none" as a NULL pointer. This is to avoid using host_iface/host_traddr in the comparison with existing connections and falsely concluding that a new connection needs to be created. Signed-off-by: Martin Belanger <[email protected]>
abhineet99
approved these changes
May 23, 2025
abhineet99
left a comment
abhineet99
left a comment
There was a problem hiding this comment.
Verified this on the setup where I could reproduce the error without the fix, thanks.
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to determine if a candidate configuration matches an existing controller connection, treat the candidate's host_iface or host_traddr set to "none" as a NULL pointer.
This is to avoid using host_iface/host_traddr in the comparison with existing connections and falsely concluding that a new connection needs to be created.
This should fix issue: linux-nvme/nvme-cli#2824