Skip to content

makefile fixes#1012

Merged
igaw merged 2 commits intolinux-nvme:masterfrom
igaw:fix-static-build
May 19, 2025
Merged

makefile fixes#1012
igaw merged 2 commits intolinux-nvme:masterfrom
igaw:fix-static-build

Conversation

@igaw
Copy link
Copy Markdown
Collaborator

@igaw igaw commented May 19, 2025

First make the clean target behave like purge. That is what most autotools users expect.
Second, get the static build going again.

igaw added 2 commits May 19, 2025 12:38
Autotools and many handwritten Makefiles only provide a 'clean' target,
which typically removes everything. However, the 'clean' target here does
not fully do this, leaving some artifacts behind after it is run. This
leads to confusion when, after cleaning, the build step still doesn't
reflect configuration changes such as newly installed libraries.

Therefore, update the 'clean' target to behave like the 'purge' step.

Signed-off-by: Daniel Wagner <[email protected]>
The linker test doesn't include the default library configuration thus
it will not fail for a static build. Add an explicit static build test.

Signed-off-by: Daniel Wagner <[email protected]>
@igaw igaw force-pushed the fix-static-build branch from 27596f0 to c0acb39 Compare May 19, 2025 11:17
@igaw igaw merged commit 3ec3936 into linux-nvme:master May 19, 2025
12 checks passed
@igaw igaw deleted the fix-static-build branch May 19, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant