Skip to content

build: trigger manual upload PyPi releases#1004

Closed
igaw wants to merge 2 commits intolinux-nvme:masterfrom
igaw:pypi-release
Closed

build: trigger manual upload PyPi releases#1004
igaw wants to merge 2 commits intolinux-nvme:masterfrom
igaw:pypi-release

Conversation

@igaw
Copy link
Copy Markdown
Collaborator

@igaw igaw commented Apr 24, 2025 •
edited
Loading

Sometimes the upload fails for $reasons. Have something in place to manually be able to upload PyPi releases.

#967

igaw added 2 commits April 24, 2025 18:44
@igaw
build: add feature to upload historic Python releases
b5ee8ba 
Sometime the upload failed to PyPi to permission issues or network
issues. Thus add a feature to upload historic releases to PyPi.

Signed-off-by: Daniel Wagner <[email protected]>
@igaw
build: don't append dev0 for tag builds
0930a59 
src/meson.build:51:10: ERROR: library keyword argument "version" Invalid Shared library version "1.12.dev0". Must be of the form X.Y.Z where all three are numbers. Y and Z are optional.

Signed-off-by: Daniel Wagner <[email protected]>
@igaw
Copy link
Copy Markdown
Collaborator Author

igaw commented Apr 24, 2025

@glimchb could you review this? thanks!

@igaw igaw mentioned this pull request Apr 24, 2025
Closed
glimchb
glimchb suggested changes Apr 24, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@glimchb glimchb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think you need it
when you trigger manually., you can just specify the branch/tag and action will already run there, see

image

@igaw
Copy link
Copy Markdown
Collaborator Author

igaw commented Apr 25, 2025

I triggered a manual build for the v1.12 tag from the master branch. The checkout is from master and not v1.12:

https://github.com/linux-nvme/libnvme/actions/runs/14658644341/job/41138093843

The documentation on workflow_dispatch indicates that the workflow can be run on any branch, but that doesn't seem to be the case here. https://docs.github.com/en/actions/managing-workflow-runs-and-deployments/managing-workflow-runs/manually-running-a-workflow

There must be something off in the current workflow...

@igaw
Copy link
Copy Markdown
Collaborator Author

igaw commented Apr 25, 2025 •
edited
Loading

Do we just need to update the initial checkout step to consider github.event.inputs.tag?

@igaw
Copy link
Copy Markdown
Collaborator Author

igaw commented May 7, 2025

I really don't want to spend any more time on this topic. Thus I'll drop this, I really don't care if PyPi gets updates or not.

@igaw igaw closed this May 7, 2025
@igaw igaw deleted the pypi-release branch July 8, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@glimchb glimchb glimchb requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@igaw @glimchb